astrelni added inline comments.
================ Comment at: test/clang-tidy/abseil-upgrade-duration-conversions.cpp:142 + +template <typename T> void templateForOpsSpecialization(T) {} +template <> ---------------- JonasToth wrote: > astrelni wrote: > > JonasToth wrote: > > > what about non-type template parameters? Do they need consideration for > > > the check as well? > > > If i am not mistaken floats are allowed in newwer standards as well. > > IIUC non-type template parameters should be no different for this check. > > This particular case is to make sure explicit specializations are treated > > differently from instantiations and get fix-it hints. > Please test in that case that the behaviour is as expected. Added some cases. I hope I interpreted correctly that "in that case" meant for template specializations / instantiations for non type template parameters. https://reviews.llvm.org/D53830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits