alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one more comment. Please address other reviewers' comments though.
================
Comment at: clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp:153
+ // required so we provide only a warning.
+ std::sort(MatchedTemplateLocations.begin(), MatchedTemplateLocations.end());
+ for (SourceLocation Loc : MatchedInstantiationLocations) {
----------------
MatchedTemplateLocations can be a std::set<SourceLocation> or a
std::unordered_set<unsigned> filled with SourceLocation::getRawEncoding(). Same
for MatchedInstantiationLocations, I suppose.
https://reviews.llvm.org/D53830
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
