ioeric added inline comments.

================
Comment at: lib/Sema/CodeCompleteConsumer.cpp:557
+      if (!Tags.empty())
+        OS << " (" << llvm::join(Tags, ",") << ")";
+      if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString(
----------------
ilya-biryukov wrote:
> NIT: Maybe add a space between the items, i.e. join with `", "` as a 
> separator?
Considering we put everything in one line, I think it's reasonable to drop the 
spaces to keep the output compact. These tags are more expected to be read by 
tests than human after all.


Repository:
  rC Clang

https://reviews.llvm.org/D53635



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to