ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM with a NIT ================ Comment at: lib/Sema/CodeCompleteConsumer.cpp:557 + if (!Tags.empty()) + OS << " (" << llvm::join(Tags, ",") << ")"; + if (CodeCompletionString *CCS = Results[I].CreateCodeCompletionString( ---------------- NIT: Maybe add a space between the items, i.e. join with `", "` as a separator? Repository: rC Clang https://reviews.llvm.org/D53635 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits