sammccall added inline comments.
================
Comment at: clangd/index/dex/dexp/Dexp.cpp:65
+ clang::clangd::SymbolID SymID;
+ // We choose the first one if there are overloaded symbols.
+ Index->fuzzyFind(Request, [&](const Symbol &Sym) {
----------------
I don't think this is reasonable behavior. I'd suggest either of:
- processing all results (this function would return a vector)
- treat this as an error, the error message should include the ID of each
symbol so we can rerun the command in an unambiguous way
================
Comment at: clangd/index/dex/dexp/Dexp.cpp:173
+ llvm::outs()
+ << "Missing required argument: please provide -id or -name.\n";
+ return;
----------------
nit: just "id" with no dash
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53019
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
