hokein added inline comments.
================
Comment at: clangd/index/dex/dexp/Dexp.cpp:204
{"lookup", "Dump symbol details by ID", llvm::make_unique<Lookup>},
+ {"refs", "Find references by qualified name", llvm::make_unique<Refs>},
};
----------------
sammccall wrote:
> I'm not sure "by qualified name" is a good idea, at least as the only option:
> - if there are overloads, you can't choose the right one (possible fix: make
> this a named flag like `refs --name foo::bar`)
> - you can't search for refs for std::unique without getting std::unique_ptr
> (possible fix: postfilter by name)
> - it seems inconsistent with Lookup (possible fix: update both)
>
>
Sounds fair enough. I think query the symbol by "qualified_name" would be more
convenient and practical when we use the tool. ID is not quite straight-forward.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53019
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
