xbolva00 added inline comments.

================
Comment at: lib/Sema/SemaChecking.cpp:10883
+          precision = AdjustPrecision(precision);
+          FloatValue.toString(PrettyTargetValue, precision);
+          IntValue.toString(PrettySourceValue);
----------------
erichkeane wrote:
> I wonder if this call (finding the precision, 'adjusting' it, then writing to 
> a smallstring might be a better thing to pull into its own function rather 
> than AdjustPrecision.
I go thru LLVM code and I see we use rmNearestTiesToEven. So I am gonna change 
it.


https://reviews.llvm.org/D52835



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to