ilya-biryukov added a comment.

> I would call it a requirement instead of an assumption. The replay must be 
> exactly the same (even the file stats and reads). If Clang reads the file in 
> replay which was only stat()ed during compilation, it indicates 
> non-determinism or something wrong (in clang or FS).
>  We currently deal with such files by adding empty buffers for them based on 
> this assumption/requirement only.

Does adding a flag to clang to skip the module inputs checks seems 
feasible/reasonable? +1 to Sam's comments, the mode for FS that has the file 
sizes, but not the file contents seems too specific for the use-case at hand, 
does not fit well into the design.


Repository:
  rC Clang

https://reviews.llvm.org/D52620



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to