efriedma added a comment.

Could we make CreateOrReplaceCXXRuntimeVariable take the alignment as an 
argument, so we can be sure we're consistently setting the alignment for these 
variables?  This seems easy to mess up if we're scattering calls all over the 
place.

Sort of orthogonal, but CreateOrReplaceCXXRuntimeVariable should probably also 
call setUnnamedAddr, instead of making each caller call it.


https://reviews.llvm.org/D51416



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to