ioeric added inline comments.
================
Comment at: clang-tools-extra/clangd/index/Index.cpp:186
+ O.map("ProximityPaths", Request.ProximityPaths);
+ if (OK)
+ Request.MaxCandidateCount = MaxCandidateCount;
----------------
I think we should not set `Request.MaxCandidateCount` if `MaxCandidateCount` is
greater than `std::numeric_limits<int32_t>::max()`?
================
Comment at: clang-tools-extra/clangd/index/Index.h:440
/// return more than this, e.g. if it doesn't know which candidates are best.
- size_t MaxCandidateCount = std::numeric_limits<size_t>::max();
+ uint32_t MaxCandidateCount = std::numeric_limits<uint32_t>::max();
/// If set to true, only symbols for completion support will be considered.
----------------
Or use `unsigned`?
https://reviews.llvm.org/D51860
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
