JonasToth added a comment. I think you dont need tests there. Its just life insurance :)
I'd stick with pointers because working with the AST always results in pointers. It is more convenient to stay in pointerland there. >> I feel that the `findMutation...` functions that take raw pointers should >> get the assertions though, at least the ones in the public interface. Having >> them for the private ones won't hurt either. > > I could do that. > But should that come with tests? > Or do we want to also take references there? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51884 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
