lebedev.ri added a comment.

In https://reviews.llvm.org/D51884#1229460, @shuaiwang wrote:

> LGTM :)


Thank you for the review!

In https://reviews.llvm.org/D51884#1229463, @JonasToth wrote:

> I feel that the `findMutation...` functions that take raw pointers should get 
> the assertions though, at least the ones in the public interface. Having them 
> for the private ones won't hurt either.


I could do that.
But should that come with tests?
Or do we want to also take references there?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D51884



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to