ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tools-extra/clangd/index/dex/Iterator.cpp:41 assert(!reachedEnd() && "DOCUMENT iterator can't advance() at the end."); + if (peek() >= ID) + return; ---------------- Maybe add a short comment that this gives performance boost? Otherwise this looks redundant when reading the code https://reviews.llvm.org/D51802 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits