rsmith marked an inline comment as done.
rsmith added inline comments.

================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881
+    SpellingKind K = (SpellingKind)Kind;
+    // FIXME: Why are Microsoft spellings not listed?
+    if (K == SpellingKind::Microsoft)
----------------
aaron.ballman wrote:
> We don't actually support Microsoft's attribute spellings currently and have 
> no attributes there to document. I think the fixme should probably read 
> "TODO: support documenting Microsoft spellings" or something more concrete.
Done. (I accidentally pushed the old version, so this is done in r341100.)

For what it's worth, we have one `Microsoft` spelling listed in the .td file 
already (but I assume this has no effect):

```
def Uuid : InheritableAttr {
  let Spellings = [Declspec<"uuid">, Microsoft<"uuid">];
```


Repository:
  rL LLVM

https://reviews.llvm.org/D51473



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D51473: I... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D514... Aaron Ballman via Phabricator via cfe-commits
    • [PATCH] D514... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D514... Richard Smith - zygoloid via Phabricator via cfe-commits
      • Re: [PAT... Aaron Ballman via cfe-commits
        • Re: ... Richard Smith via cfe-commits
          • ... Aaron Ballman via cfe-commits

Reply via email to