aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM with a commenting nit. Thank you for this, I like this exposition better! ================ Comment at: utils/TableGen/ClangAttrEmitter.cpp:3881 + SpellingKind K = (SpellingKind)Kind; + // FIXME: Why are Microsoft spellings not listed? + if (K == SpellingKind::Microsoft) ---------------- We don't actually support Microsoft's attribute spellings currently and have no attributes there to document. I think the fixme should probably read "TODO: support documenting Microsoft spellings" or something more concrete. Repository: rC Clang https://reviews.llvm.org/D51473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
