hokein added inline comments.
================ Comment at: test/clang-tidy/Inputs/absl/external-file.h:1 +void DirectAcess2() { absl::strings_internal::InternalFunction(); } + ---------------- The file can not self-compile, and we should make it compilable. And put the newly-added code at the end of the file, so that other test file can keep unchanged. ================ Comment at: test/clang-tidy/Inputs/absl/strings/internal-file.h:34 +} // namespace absl + ---------------- nit: remove the empty line. https://reviews.llvm.org/D50542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits