hokein added a comment. Please rebase your patch, since the absl matcher patch is submitted. Thanks.
================ Comment at: test/clang-tidy/abseil-no-internal-deps.cpp:8 +#include "absl/external-file.h" +// CHECK: absl/external-file.h:1:23: warning: do not reference any 'internal' namespaces; those implementation details are reserved to Abseil [abseil-no-internal-deps] + ---------------- hugoeg wrote: > hokein wrote: > > Does the test get passed on the first run `RUN: %check_clang_tidy %s > > abseil-no-internal-deps %t, -- -- -I %S/Inputs` of the test? It will > > suppress clang-tidy warnings from the header, and the warning here should > > not appear. > Yes, the test passes cleanly on both runs, I just re ran it a couple times to > make sure. Yeah, I misread it as `CHECK-MESSAGE`. https://reviews.llvm.org/D50542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
