silvas added a comment.

Can you elaborate on why this patch is restricted to unix?

Also, this probably requires some documentation in
http://llvm.org/docs/CMake.html
(we don't really have an analogous page just for clang currently, so the llvm 
one is probably the best place right now)


================
Comment at: utils/perf-training/CMakeLists.txt:21
@@ +20,3 @@
+  add_custom_target(clear-profraw
+    COMMAND find ${CMAKE_CURRENT_BINARY_DIR} -name "*.profraw" -print | xargs 
rm
+    COMMENT "Clearing old profraw data")
----------------
Can you write a tiny pure-Python helper script for clear-profraw and another 
for generate-profdata? That will be more portable.

If this is the only thing blocking windows support, I think that shooting for 
windows support on the initial patch is worth a shot.





http://reviews.llvm.org/D15462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to