mclow.lists accepted this revision. mclow.lists added a comment. In https://reviews.llvm.org/D46845#1183462, @erik.pilkington wrote:
> In https://reviews.llvm.org/D46845#1183435, @mclow.lists wrote: > > > One more thing - > > When you add a new header file, you need to update > > `include/module.modulemap`, `test/libcxx/double_include.sh.cpp`, and > > `include/CMakeLists.txt`. > > Take a look at https://reviews.llvm.org/D49338 for an example. > > > Are you sure we have to update test/libcxx/double_include.sh.cpp? Looks like > that file only has public headers, but this patch only adds `__node_handle`, > which is internal. The new patch adds this header to include/CMakeLists.txt > though (`__node_handle` already appeared in module.modulemap) D'oh! You're right. I didn't see that you had a patch for `module.modulemap`. Sorry for the noise. Go ahead and commit (and thanks for doing this!) https://reviews.llvm.org/D46845 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
