labrinea added a comment.

Hi Eric,

The main optimization I feel is useful is mem2reg. Without that, if I want to 
properly check the right values go to the right operands of the intrinsic calls 
I have to write FileCheck matchers that match stores and their relevant loads, 
plus bitcasts. This not only looks more obfuscated than matching the mem2reg 
output, but it is also less resilient to changes in the way clang code 
generates.

The generated IR for each intrinsic is around 50 lines. I can just pick out the 
particular instructions I want to check, as you suggested, but they won't we 
connected by the flow of values. In my opinion such a test will be less 
valuable.

I can do this both ways but my preferred way is to run the bare minimum of 
optimization to de-cruft the output and make the test robust and readable. If 
you feel however that you don't want the optimizers run I will make a best 
effort at writing a test that doesn't use them.


http://reviews.llvm.org/D15223



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to