a.sidorin added a comment.

I understand your position. However, we cannot check that we don't import 
`BreakStmt` as `ContinueStmt` using just ASTMerge without any verification. As 
I understand, unit tests is what we need  because we need to check that the 
overall imported type/expression is correct. And  I think that we really need 
to create tests for all nodes with import implemented since that is a target of 
tests (yes, it can take some time, but I think it is strictly required). With 
static_assert we can perform only a limited amount of checks so I decided to 
use ASTMatchers.
But I think I can just use both approaches: I may use your tests and keep this 
unit test framework as well to perform more strict checks.


http://reviews.llvm.org/D14286



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to