sepavloff added a comment.

Unit test, of course, checks import facility but i would say this is overkill. 
You need to create tests for all nodes you implement in imported, this is huge 
amount of work.

I would propose you to move tests from http://reviews.llvm.org/D14224 for nodes 
that are implemented there, for remaining nodes create short functions, that 
have respective node in the body, similar to what is done in 
http://reviews.llvm.org/D14224. Such test checks that the node is handled in 
Importer. For regression test it must be enough. More rigorous check must can 
be done in runtime, or in constexpr function, for some nodes. Unfortunately it 
looks like constexpr attribute is not preserved correctly by the importer 
class, so we have no choice here.


http://reviews.llvm.org/D14286



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to