This one perhaps needs some discussion...

Is it better to keep the current nsgmls until we know whether all of the supported platforms are working before removing it? ie: Introduce support for running the system version (and not building the CDE version) in one patch or patches. Then when we are ready, we can remove it?

I am all for using the system version of things rather than embedded versions, but it need to be done carefully so as to not break something else.

This patch also assumes that dtudcfonted exists. It currently does not, therefore it will fail to apply right off the bat.

If you create patches that depend on other patches, you should send them all in one go (email). But keep in mind, if one fails, all of the following ones will fail too.

This is why it is a good idea to keep each topic branch you develop in as self-contained as possible for this very reason, and use many smaller commits addressing one sensible thing at a time rather than all of it in one large patch. This also makes it easier to review.

I also see that you default Nsgmls in Imake.tmpl as /usr/bin/onsgmls .

Why? At least on my Ubuntu 16.04 box, you need to install the 'sp' package, which provides nsgmls. The default should be just 'nsgmls', without the full path included. If debian boxes are using a different name for this program, then that is a problem we would need to deal with as well. How do we detect and handle this case? We only have one linux.cf file. What's it called on the BSD's?

I also see that there is yet another version (ancient) called 'sgmls' in
programs/dtdocbook/sgmls/

That one should go too I suppose.

I can't merge this as-is, but it's goal is a good one.

-jon

On 07/28/2018 08:44 AM, Chase via cdesktopenv-devel wrote:
We will now depend on the opensp package, the macro will most likely need to be changed for *bsd and solaris

Thank you for your time,
-Chase




------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot



_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel


--
Jon Trulson

"Fire all weapons and open a hailing frequency for my victory yodle."

                              - Zapp Brannigan

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
cdesktopenv-devel mailing list
cdesktopenv-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/cdesktopenv-devel

Reply via email to