Any chance I could ask you to consolidate #2 and #3 on that confluence
page to say something more like:
"Your Github repository needs to have the following webhooks enabled:
github-pull-request-hook and github-webhook. They may be already enabled
for your repository. If they are not (your Jenkins job is not invoked
for new pull-requests), please send a message to builds@apache.org
asking for the webhooks to be enabled."
Happy to edit it myself if you want to just give me the karma instead. I
didn't see an option to make/suggest the edit on my own.
Thanks again.
On 1/31/19 8:58 PM, Josh Elser wrote:
Thanks boss. That did the trick!
On 1/31/19 2:44 PM, Chris Thistlethwaite wrote:
Just added the webhooks, try another PR.
-CT
On Thu, 2019-01-31 at 14:27 -0500, Josh Elser wrote:
Thanks, Chris.
I'm looking at incubator-ratis.
On 2019/01/30 20:02:47, Chris Thistlethwaite <chr...@apache.org>
wrote:
> Josh,
Those webhook may or may not be created automatically during the
setup
of CloudBees Pull Request Builder. I say that because we have two
different service accounts Jenkins uses to connect to GH. So if the
webhook is already setup for the old GHPRB, then it will still
work,
but that's not always the case with a fresh setup.
Which repo are you trying to setup? I'll create the webhook and we
can
test again.
--
-Chris T.
#asfinfra
On Wed, 2019-01-30 at 13:29 -0500, Josh Elser wrote:
Hi all,
Trying to follow the guide up at
https://cwiki.apache.org/confluence/display/INFRA/GitHub+Pull+Request+Builder
<snip>
* Create two webhooks (this should be automatic, but it might not
be)
on
your GH repo
- https://builds.apache.org/github-pull-request-hook/
(pull_request)
- https://builds.apache.org/github-webhook/ (push)
* Add Root team to repo as an admin (also could just be asfbot,
haven't
tested that yet).
</snip>
I pushed a new PR after making a Jenkins job following the first
part
of
the guide, but assume I must be missing these hooks since
nothing
happened :)
Does anyone happen to have clarity on these two steps? Thanks!
- Josh
