On Tue, 6 Oct 2026 09:21:11 GMT, Nizar Benalla <[email protected]> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Refine scroll margin
>
> make/data/docs-resources/resources/jdk-default.css line 109:
>
>> 107: }
>> 108: }
>> 109: :root[data-underline-links="on"] {
>
> A small UI inconsistency I noticed is that when you select the dark theme and
> reload the page (without toggling the underlining link option), underlining
> the links is selected by default, but the links are not.
> Reproducing, this is possible is a lot easier if you try this in a new
> private window
> <img width="1448" height="759" alt="Screenshot 2026-10-06 at 09 15 54"
> src="https://github.com/user-attachments/assets/e2d63d5d-ca82-49de-aa39-5d52523a0988";
> />
> ot underlined.
Good catch, this got lost in the refactoring of the script. I pushed a fix and
updated the existing docs at
https://cr.openjdk.org/~hannesw/8377548/docs.01/specs/ (you may have to
shift-reload to fetch the new script and stylesheet).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33127#discussion_r4207243185
