On Fri, 2 Oct 2026 05:44:36 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Please review an enhancement to the other specifications and tool guides >> (man pages) that adds the following features: >> >> - Support for light and dark themes >> - Permalinks for headings on hover >> - Responsive layout for wide screens and mobile devices >> >> Generated documentation [can be viewed >> here](https://cr.openjdk.org/~hannesw/8377548/docs.00/specs/index.html). >> >> The implementation for the new features is shared with API documentation, >> which was refactored to make it easier to apply in specs and man pages, >> which use a variety of build mechanisms. Instead of hard-coding the theme >> selector markup everywhere it is needed as we did before, the `initTheme()` >> function now creates the whole UI. This has the added benefit that no >> disfunctional theme selector button is generated if theme support is not >> loaded for some reason. The `initTheme()` function also encapsulates the >> whole theme functionality, whereas before it was intermingled with other >> code. >> >> The JVM Tool Interface specification does not participate in the new >> features because it uses inline styles that are not compatible with themes, >> and permalink conventions for headings that are not recognized by the >> script. I can file a bug for this if it is considered a serious enough issue. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Refine scroll margin make/data/docs-resources/resources/jdk-default.css line 109: > 107: } > 108: } > 109: :root[data-underline-links="on"] { A small UI inconsistency I noticed is that when you select the dark theme and reload the page (without toggling the underlining link option), underlining the links is selected by default, but the links are not. Reproducing, this is possible is a lot easier if you try this in a new private window <img width="1448" height="759" alt="Screenshot 2026-10-06 at 09 15 54" src="https://github.com/user-attachments/assets/e2d63d5d-ca82-49de-aa39-5d52523a0988"; /> ot underlined. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33127#discussion_r4193595340
