On Mon, 13 Jul 2026 15:17:13 GMT, Ashay Rane <[email protected]> wrote:
>> src/hotspot/os_cpu/windows_aarch64/pauth_windows_aarch64.inline.hpp line 34:
>>
>>> 32:
>>> 33: inline address pauth_strip_pointer(address ptr) {
>>> 34: return pauth_drop_signature_win_arm64(ptr);
>>
>> In the implementation in
>> `src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp`, we also
>> try to strip the signature from the first parameter using instruction
>> `XPACLRI`. I was wondering if we could use the similar and simple way as
>> Linux/AArch64 side does?
>
> I like the ergonomics of simply calling
> `ContinuationHelper::return_address_at()`, but I worry that using that
> function will create a new implicit dependency among the headers (i.e. all of
> the files that include `OS_CPU_HEADER_INLINE(path)` will also ned to include
> continuationHelper.inline.hpp).
>
> Ideally, I'd have used inline assembly, just like in
> pauth_linux_aarch64.inline.hpp, but the MSVC compiler doesn't support inline
> assembly, thus requiring that `pauth_drop_signature_win_arm64()` be defined
> in a separate .S file.
I see. Thanks for your explanation. Okay to me then.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31795#discussion_r3575187419
