On Thu, 26 Feb 2026 22:47:45 GMT, Erik Joelsson <[email protected]> wrote:
> > Erik, reading the Linux kernel commit thread linked in the JBS issue, don't > > we need two variants for this depending on which version of make we are > > using? > > I did read their patch, but I can't figure out why they chose to keep the old > implementation around. I tried with make 3.81, 4.4 and 4.4.1 and they all > work as expected with my patch. Logically there shouldn't be a difference > either. I read through the whole mail thread and there was a reason for it. I have updated the patch. Older make versions put long options before short options in MAKEFLAGS, so filtering out `--%` is needed. In practice I don't think this would ever have been an issue for us though as the only known option that only has a long name is `--warn-undefined-variables`, which I doubt anyone would use in combination with `-p -q`. Any option that has a short name appears as the short name in MAKEFLAGS. (Ref https://lists.gnu.org/archive/html/bug-make/2023-03/msg00044.html) ------------- PR Comment: https://git.openjdk.org/jdk/pull/29942#issuecomment-3969752618
