On Thu, 26 Feb 2026 19:20:29 GMT, Erik Joelsson <[email protected]> wrote:
> GNU Make 4.4.1 changed the behavior of the variable MAKEFLAGS. This is > causing our makefiles to behave weirdly in certain situations. We need to > check for certain options in MAKEFLAGS to adjust behavior, and the way we do > it is not compatible with GNU Make 4.4.1. In the GNU Make manual, it's > [documented how you should query MAKEFLAGS for > options](https://www.gnu.org/software/make/manual/make.html#Testing-Flags) > and this patch is applying this recommendation. With this patch, I can > successfully run the failing examples given in the bug using 4.4.1. I have > also verified that tab completion still works and that the output of `make -p > -q` looks the same before and after. > > Big thanks to Jaikiran who found the solution to this! Okay - maybe there is something specific to make 3.x that they had to deal with. IIUC the problem will never arise in earlier make versions because the user-supplied args will not be included in MAKEARGS. LGTM. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/29942#pullrequestreview-3863999767
