On Fri, 8 Aug 2025 15:25:15 GMT, Quan Anh Mai <qa...@openjdk.org> wrote:
>> src/hotspot/share/precompiled/precompiled.hpp line 29: >> >>> 27: >>> 28: // These header files are included in at least 130 C++ files, as of >>> 29: // measurements made in August 2025. >> >> I don't think there's anything particularly special about the number 130. >> >> Another thing to consider when a header file has a high include count is >> whether it's being overincluded. We've had lots of those, and some folks >> occasionally try to poke at that problem. Some of the removals here look like >> they might be a result of such efforts. >> >> Still another thing to consider is the cost of inclusion. Some files may just >> be a lot more expensive to process and benefit more for being precompiled. >> File size can be an indicator, but there are others. Unfortunately, I don't >> know of a good way to measure this. > > You need to modify the comment here, too. Right, I'll wait just a bit so the discussion on how to approach the problem stabilizes :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2263289968
