On Fri, 8 Aug 2025 06:30:11 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Francesco Andreuzzi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> script. update > > src/hotspot/share/precompiled/precompiled.hpp line 29: > >> 27: >> 28: // These header files are included in at least 130 C++ files, as of >> 29: // measurements made in August 2025. > > I don't think there's anything particularly special about the number 130. > > Another thing to consider when a header file has a high include count is > whether it's being overincluded. We've had lots of those, and some folks > occasionally try to poke at that problem. Some of the removals here look like > they might be a result of such efforts. > > Still another thing to consider is the cost of inclusion. Some files may just > be a lot more expensive to process and benefit more for being precompiled. > File size can be an indicator, but there are others. Unfortunately, I don't > know of a good way to measure this. You need to modify the comment here, too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26681#discussion_r2263274537
