On Fri, 24 Jan 2025 14:58:24 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> The Linux PPC64 PCH build was broken after JDK-8347909. >> Build error >> >> * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrans.o: >> cc1plus: error: >> /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch: >> created and used with differing settings of '-mpower8-fusion-sign' >> [-Werror=invalid-pch] >> cc1plus: error: one or more PCH files were found, but they were invalid >> <command-line>: fatal error: precompiled.hpp: No such file or directory >> >> * For target hotspot_variant-server_libjvm_objs_sharedRuntimeTrig.o: >> cc1plus: error: >> /jdk25_opt/hotspot/variant-server/libjvm/objs/precompiled/precompiled.hpp.gch: >> created and used with differing settings of '-mpower8-fusion-sign' >> [-Werror=invalid-pch] >> cc1plus: error: one or more PCH files were found, but they were invalid >> <command-line>: fatal error: precompiled.hpp: No such file or directory >> >> >> There was a mismatch of the build settings of precompiled.hpp.gch and these >> 2 compilation units leading to this error; the PCH build exclusion of these >> 2 files did not work. > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > adjust gcc PCH exclusion on ppc64le make/hotspot/lib/JvmOverrideFiles.gmk line 60: > 58: ifeq ($(TOOLCHAIN_TYPE), clang) > 59: JVM_PRECOMPILED_HEADER_EXCLUDE := \ > 60: sharedRuntimeTrig.cpp \ Thank you for fixing the tabs, but please use four spaces of indentation when breaking lines with \ (as opposed to increasing the logical indentation in blocks). The same goes for your newly added gcc block below. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23268#discussion_r1928953741
