On Fri, 24 Jan 2025 08:56:59 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> I must admit I did not realize this list was dependent on the `opt-size` >> feature, so I cannot say if my patch really works with that enabled. Maybe >> the OPT_SPEED_SRC list is needed then, after all. >> >> Nevertheless, I think we can limit the change for ppc on gcc. When I added >> the -W flag for more detailed warnings, I was taught that it was the value >> of some -mpower-..somethingsomething flag that was problematic for PCHs. So >> it seems like it could be a very much PPC specific problem. > >> Nevertheless, I think we can limit the change for ppc on gcc. > > That's fine. Do you want to do it in your PR or should I do it in this one? I think it is better to do this change separately here; I intend to remove the corresponding changes in my PR. Did you test what happened when opt-size was configured, if you needed to exclude all the files in OPT_SPEED_SRC as well? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23268#discussion_r1928557659
