On Tue, 12 Nov 2024 15:38:41 GMT, SendaoYan <s...@openjdk.org> wrote:

>> Hi all,
>> After [JDK-8338304](https://bugs.openjdk.org/browse/JDK-8338304), below 
>> configure command will generate failure `error: Could not find required tool 
>> for LLD`. The lld linker located in path which config with option 
>> `--with-toolchain-path`, but the check `UTIL_REQUIRE_PROGS(LLD, lld)` 
>> introduced by [JDK-8338304](https://bugs.openjdk.org/browse/JDK-8338304) was 
>> unable to find the lld. This PR add the condition to deal with user 
>> specidied `--with-toolchain-path` to find the correct lld fullpath. The 
>> change has beeen verified locally, trivial fix, the risk is low.
>> 
>> 
>> bash configure --with-jobs=128 --with-debug-level=release 
>> --enable-unlimited-crypto --with-jvm-variants=server 
>> --with-version-opt=f4008968 --with-zlib=system --with-toolchain-type=clang 
>> --with-toolchain-path=/home/yansendao/software/acc/x86_64/bin
>
> SendaoYan has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   lookup $TOOLCHAIN_PATH:$PATH

Thanks all for the advice and review. The change has been verified locally.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21999#issuecomment-2471146323

Reply via email to