On Tue, 12 Nov 2024 15:08:02 GMT, SendaoYan <s...@openjdk.org> wrote:
>> After I remove the lld binary from `$TOOLCHAIN_PATH`, such as `mv >> /home/yansendao/software/acc/x86_64/bin/lld /tmp/`, the configure command >> generate `configure: error: Could not find required tool for LLD` as >> expected. > > If the statement `UTIL_REQUIRE_PROGS(LLD, lld)`lookup in `$PATH`, the line 77 > condition statement in this PR has make sure that, and if the configure > command doesn't received option `--with-toolchain-path`, the normal lookup in > `$PATH` still work. I meant, if you have lld in your PATH but not in TOOLCHAIN_PATH and you specify a toolchain path, then your patch will introduce a regression. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21999#discussion_r1838312868
