On Thu, 5 Sep 2024 10:17:11 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update GetJREPath comment and remove unnecessary JLI_IsStaticallyLinked
>> check
>
> src/java.base/unix/native/libjli/java_md.c line 509:
>
>> 507:
>> 508: if (GetApplicationHome(path, pathsize)) {
>> 509: if (JLI_IsStaticallyLinked()) {
>
> In passing, GetJREPath's function description includes "or registry settings"
> which is confusing to see now.
I updated the description.
Also, the name "JRE" is severly outdated, but cleaning out technical debt in
the JLI library will have to wait for another day.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1801728335
