On Thu, 5 Sep 2024 00:15:35 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update GetJREPath comment and remove unnecessary JLI_IsStaticallyLinked
>> check
>
> src/java.base/unix/native/libjli/java_md.c line 509:
>
>> 507:
>> 508: if (GetApplicationHome(path, pathsize)) {
>> 509: if (JLI_IsStaticallyLinked()) {
>
> `GetJREPath()` does not need to be called for the static case. Any reason why
> this path is executed for static mode?
I guess this is parts of my initial attempt to get the static launcher to work
on macOS. I agree that it should not be needed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1801727521
