On Thu, 14 Mar 2024 15:56:42 GMT, Erik Joelsson <er...@openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains four >> additional commits since the last revision: >> >> - Merge branch 'master' into set-libcxx-automatically >> - Fix extra space >> - Restore $(LIBCXX) in tests since they don't use SetupJdkLibrary. >> - 8328146: Set LIBCXX automatically > > make/modules/jdk.jpackage/Lib.gmk line 132: > >> 130: LDFLAGS := $(LDFLAGS_JDKLIB) $(LDFLAGS_CXX_JDK) \ >> 131: $(call SET_SHARED_LIBRARY_ORIGIN), \ >> 132: LIBS := advapi32.lib ole32.lib msi.lib user32.lib \ > > Should this (and the others below) be using LINK_TYPE:=C++ or was $(LIBCXX) > never actually needed on Windows? $(LIBCXX) is not needed on Windows. It is used only on gcc, where it expands to flags needed to link statically with the C++ standard libraries, if static linking with the standard libs is selected. There's overall a lot of messiness with the flags, with setting flags that is pointless, or omitting to set flags that we should (due to copy/paste once again). These initial PRs I've posted try to keep the same flags for all libraries. The fun (or "fun") part comes after that, when I'll try to modify the flags to make more sense. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18298#discussion_r1525585786
