On Thu, 14 Mar 2024 13:29:05 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> We are adding LIBCXX to LIBS in calls to SetupJdkLibrary whenever LINK_TYPE >> is C++. We should do this automatically in SetupJdkLibrary for C++ linking. >> >> I also removed the superfluous `-lc` from some places where it had been >> added. > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Fix extra space > - Restore $(LIBCXX) in tests since they don't use SetupJdkLibrary. I have verified with COMPARE_BUILD that there is no significant difference in the build result with or without this patch on Oracle default CI platforms (linux x64/aarch64, macos x64/aarch64, windows x64). ------------- PR Comment: https://git.openjdk.org/jdk/pull/18298#issuecomment-1997486448
