Hi/2. 2014-11-18 13:36 GMT+09:00 Paul Eggert <egg...@cs.ucla.edu>:
> That patch doesn't look right to me. First, the "#if MSDOS" and "#if > defined(__OS2__)" sections of code have a lot in common, and this common > part shouldn't be duplicated. Ok. > Second, it really should be using the binary-io module, as I mentioned > earlier. No problem. But any special reasons why binary-io module of gnulib should be used instead of pre-existent SET_BINARY_MODE() ? In addition, SET_BINARY_MODE() is being used already. > Third and most important, whether a file descriptor should be placed into > binary mode ought to be a function of whether binary data is being read or > written, not whether the file is a terminal. Not every use of "tar" writes > binary data to stdout. > Ok.
