Re: [Bug-tar] [PATCH 2/2] tar: set stdin/stdout to binary mode on OS/2 if not console

[Paul Eggert]

That patch doesn't look right to me.  First, the "#if MSDOS" and "#if 
defined(__OS2__)" sections of code have a lot in common, and this common part 
shouldn't be duplicated.  Second, it really should be using the binary-io 
module, as I mentioned earlier.  Third and most important, whether a file 
descriptor should be placed into binary mode ought to be a function of whether 
binary data is being read or written, not whether the file is a terminal.  Not 
every use of "tar" writes binary data to stdout.