Follow-up Comment #6, bug #27809 (project make):
Thanks Ozkan. A few comments about the parts of the patch that are not
Windows-specific.
First you mention compiler warning fixes for UNIX, but none of the changes
you mention fix any warnings I see on my UNIX tests (different platforms but
using gcc -Wall on all of them). Which ones do you see?
Second, I'm not thrilled about adding a lot MORE ifdefs just to allow for
debugging statements. I think we need to find a better way to handle this
part. I'll think about it and check my ISO C 1989 standard (I can't remember
whether it supports %p) when I get back to work on Tuesday.
Third, I really don't understand why the casts in ar.c and arscan.c are
necessary. Those members are already of type char* (through array decay) and
it's perfectly reasonable to pass a char* to a function requiring a const
char* without any cast required. I really don't like to use casts unless
absolutely necessary (I've worked to REDUCE the total amount of casting in GNU
make source) so I'd definitely prefer to avoid these.
Finally, it seems that some of these changes are meant to avoid variable
names conflicting with function names (open, etc.) Is this really a warning
that some compilers give? I've never seen that warning, and it sure seems to
me like it would be almost impossible to write a portable C program that
didn't hit that warning, since every C runtime defines a horde of functions
and there is no way to know what they all are. I don't like it.
_______________________________________________________
Reply to this item at:
<http://savannah.gnu.org/bugs/?27809>
_______________________________________________
Message sent via/by Savannah
http://savannah.gnu.org/
_______________________________________________
Bug-make mailing list
Bug-make@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-make
