Hello, Thanks for having a look at it.
Gianluca Cannata, le lun. 26 oct. 2026 11:09:27 +0100, a ecrit: > diff --git a/rumpdisk/Makefile b/rumpdisk/Makefile > index de33c65d..48e9a918 100644 > --- a/rumpdisk/Makefile > +++ b/rumpdisk/Makefile > @@ -17,6 +17,7 @@ > > RUMPLIBS=rump rumpuser rumpdev rumpdev_disk rumpdev_pci rumpvfs > RUMPSATA=rumpdev_ahcisata rumpdev_piixide rumpdev_ata > +RUMPNVME=rumpdev_nvme rumpdev_ld ? Those libraries do not exest at the moment. > RUMPUSB=rumpdev_usb rumpdev_pci_usbhc rumpdev_umass rumpdev_scsipi > RUMPEXTRA=rumpdev_scsipi > > @@ -51,6 +52,15 @@ rumpdisk.static-LDLIBS += $(HURDLIBS:%=-l%) > $(RUMPSTATIC) $(RUMPEXTRA:%=-l%_pic) > -Wl,--whole-archive $(RUMPSATA:%=-l%_pic) > $(RUMPLIBS:%=-l%_pic) -Wl,--no-whole-archive > rumpdisk rumpdisk.static: $(rumpdisk-OBJS) > > +%.nvme.o: %.c > + $(CC) $(CFLAGS) $(CPPFLAGS) -DRUMP_NVME -c $< -o $@ > +rumpdisk-OBJS = $(SRCS:.c=.nvme.o) > +rumpdisk-LDLIBS += $(HURDLIBS:%=-l%) $(RUMPSTATIC) $(RUMPEXTRA:%=-l%) \ > + -Wl,--no-as-needed $(RUMPNVME:%=-l%) $(RUMPLIBS:%=-l%) > -Wl,--as-needed > +rumpdisk.static-LDLIBS += $(HURDLIBS:%=-l%) $(RUMPSTATIC) > $(RUMPEXTRA:%=-l%_pic) \ > + -Wl,--whole-archive $(RUMPNVME:%=-l%_pic) > $(RUMPLIBS:%=-l%_pic) -Wl,--no-whole-archive > +rumpdisk rumpdisk.static: $(rumpdisk-OBJS) This is overriding the rules above. You don't need new rules, you just need to add the NVME part in the existing rule above. > %.usb.o: %.c > $(CC) $(CFLAGS) $(CPPFLAGS) -c $< -o $@ > rumpusbdisk-OBJS = $(SRCS:.c=.usb.o) > diff --git a/rumpdisk/block-rump.c b/rumpdisk/block-rump.c > index aa4a387f..4512de22 100644 > --- a/rumpdisk/block-rump.c > +++ b/rumpdisk/block-rump.c > @@ -47,10 +47,12 @@ > #define BLKRRPART 0x125F /* re-read partition table */ > > #define DISK_NAME_LEN 32 > -#define MAX_DISK_DEV 2 > +#define MAX_DISK_DEV 3 > > #ifdef _RUMP_SATA > #define RUMP_TYPE_STRING "rump SATA/IDE" > +#elif defined(_RUMP_NVME) > +#define RUMP_TYPE_STRING "rump NVMe" I don't think we really want to have a different translator for SATA and NVMe. For USB the question is different because the USB stack will bring complexity and we'll want to manage that differently. I.e. you'd just add the nvme part in the _RUMP_SATA case. Samuel
