Re: [PATCH 6/8] killall5.c: Use sysconf(_SC_SYMLOOP_MAX) instead of MAXSYMLINKS.

[Pino Toscano]

Alle martedì 9 luglio 2013, Justus Winter ha scritto:
> index 5937d98..02ac88f 100644
> --- a/src/killall5.c
> +++ b/src/killall5.c
> @@ -373,7 +373,7 @@ int check4nfs(const char * path, char * real)
>  {
>       char buf[PATH_MAX+1];
>       const char *curr;
> -     int deep = MAXSYMLINKS;
> +     int deep = sysconf(_SC_SYMLOOP_MAX);

While certainly better, I just verified that such sysconf returns -1 on 
Linux and kFreeBSD; thus, maybe it would make more sense to move this 
code in a small function, which would first use sysconf falling back (if 
returning <= 0) to MAXSYMLINKS if defined.

-- 
Pino Toscano

signature.asc
Description: This is a digitally signed message part.