Hi! Generally OK, but two comments:
On Mon, 24 Sep 2012 00:04:20 +0200, Pino Toscano <toscano.p...@tiscali.it> wrote: > Subject: [PATCH] configure: add --with-version-suffix=STRING > > Add the possibility to append a custom string to the gnumach version string. > (Useful to distinguish different flavours of kernel.) > > * configure.ac (--with-version-suffix): New option. > (PACKAGE_VERSION_SUFFIX): New variable, set with the value of > --with-version-suffix. > * version.c.in (version): Append PACKAGE_VERSION_SUFFIX. > --- > configure.ac | 8 ++++++++ > version.c.in | 2 +- > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 3a7d3be..da5e09e 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -101,6 +101,14 @@ AC_CHECK_PROG([PATCH], [patch], [patch], > [patch-not-found]) > # configure fragments. > # > > +# An optional suffix for the version string. > +AC_MSG_CHECKING([for the suffix for the version string]) > +AC_ARG_WITH(version-suffix, AC_HELP_STRING([--with-version-suffix=STRING], > + [append STRING to the version string]), > + [PACKAGE_VERSION_SUFFIX=$withval]) > +AC_MSG_RESULT([$PACKAGE_VERSION_SUFFIX]) > +AC_SUBST([PACKAGE_VERSION_SUFFIX]) Does the AC_MSG_CHECKING and AC_MSG_RESULT add any useful information to the build log? (You should know which option you're configuring with.) Is --with-version-suffix the standard name for this option? Grüße, Thomas
pgpLENZt75Muy.pgp
Description: PGP signature
