Hi, On Tue, May 25, 2010 at 09:10:57PM +0200, Carl Fredrik Hammar wrote: > On Mon, May 24, 2010 at 12:08:10PM +0200, Emilio Pozuelo Monfort wrote:
> The first three patches are pretty useless on their own, they all > affect the same program, and most changes are pretty mechanical, so I > think you might as well merge them. Indeed -- while I support this kind of gradual changes in general, it's probably overdoing it a bit here :-) > I've commented on every hunk to make sure I looked through it all, > which makes it a bit long but hopefully easy to follow (complain if it > isn't). Well, it certainly does make it pretty redundant... > > +/* Deprecated. Use exec_exec_file_name instead. */ > > A colon would be better: ``Deprecated: use ...''. Or perhaps a semi-colon, or a dash? Punctuation can be so exciting... ;-) -antrik-
