At Mon, 30 Jan 2006 15:37:53 -0200,
Matheus Morais wrote:
>
> Please review, diff file in attached.
Thanks for the contribution. When submitting patches please follow
the following conventions: a description of what you are trying to
accomplish and why. In your case, you should have explained why you
think add_bsd_partition needs to be moved. You allude to it in the
subjuct but what is the warning? How does moving the code fix it?
Second, you need to include a change log. See the ChangeLog files in
the source tree for examples.
Thanks,
Neal
The warning is 'add_bsd_partition is defined but not used', so I moved add_bsd_partition to inside the 'ifdef' wich that procedure is called avoiding the warning message because it will be declared only if it will be used.
ChangeLog
2006-01-30 Matheus Morais <[EMAIL PROTECTED]>
*add_bsd_partition() moved because warning messages of defined but not used procedure
So, its good or I need to improve in that specifications?
Thanks
Matheus Morais
_______________________________________________ Bug-hurd mailing list Bug-hurd@gnu.org http://lists.gnu.org/mailman/listinfo/bug-hurd
