Hi Ludovic, Ludovic Courtès <l...@gnu.org> writes:
> Hi Maxim, > > Maxim Cournoyer <maxim.courno...@gmail.com> writes: > >> There is a discrepancy in our build environment, where the build user's >> directory is set to '/' while HOME is set to '/homeless-shelter'. >> Normally both should match, and it trips some test suite that assumes >> this to be the case, as with libssh's [0]. >> >> Perhaps '/homeless-shelter' could be made to more simply be '/', or >> pw_dir could be made to be '/homeless-shelter'. >> >> What do you think? > > As a rule of thumb, the build environment should never change so that > things that derivations that succeeded one day still succeed years > later. > > So my take is that we should live with this discrepancy forever and > ever. I was worried you'd say this :-). But it's true, that it could be annoying to have something fail with old daemon and pass with newer ones, or vice-versa when using time-machine. > (Note that the unprivileged daemon does introduce some discrepancies, > and this is something we should fix as much as possible.) Hm, perhaps if the 'as much as possible' != 'everything', we could use this breaking opportunity to bundle a few changes like this one? A way that could perhaps be used here would be to bump the daemon's version, and expose this to the build so that some phases code can be conditional to the daemon version. Not very elegant, but it'd at least allow us fixing this kind of issue in the daemon. I'll close this issue for now, but if you have some thoughts on the above idea, feel free to continue this discussion here! -- Thanks, Maxim
