Hi Simon, Simon Tournier <zimon.touto...@gmail.com> writes:
> Hi Maxim, > > On Thu, 30 May 2024 at 22:59, Maxim Cournoyer <maxim.courno...@gmail.com> > wrote: > >> + (source (origin >> + (inherit (package-source patch)) >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://git.savannah.gnu.org/git/patch.git";) >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "1bk38169c0xh01b0q0zmnrjqz8k9byz3arp4q7q66sn6xwf94nvz")))) > > If I read correctly, (package-source patch) reads: > > (source (origin > (method url-fetch) > (uri (string-append "mirror://gnu/patch/patch-" > version ".tar.xz")) > (sha256 > (base32 > "1zfqy4rdcy279vwn2z1kbv19dcfw25d2aqy9nzvdkq5bjzd0nqdc")) > (patches (search-patches "patch-hurd-path-max.patch")))) > > Therefore the only thing that is copied is the ’patches’ field. Right? > > I think it would easy the readability to avoid ’inherit’ and plainly > write ’patches’. I preferred inheritance to avoid having to manually sync things in the long run... (hopefully the graft gets ungrafted before 'patch' amasses new phatces, but we never know...) -- Thanks, Maxim
