Nikita Karetnikov <nik...@karetnikov.org> skribis: >> You can if you end up not using the “syntactic constructor” with named >> fields (as was the case in my example). > > Heh, I used it; it's very handy. I didn't even try to use > 'gnu-package-descriptor'. > > Thanks for your suggestions. Any other comments? If not, I'll create a > proper patch (the attached version doesn't honor multiple fields).
Looks good to me! Nitpicking follows: > + #:use-module (ice-9 rdelim) ; http-fetch* The comment is misleading. > + (gplv3-status gnu-package-gplv3-status) > + (activity-status gnu-package-activity-status) > + (last-contact gnu-package-last-contact) > + (next-contact gnu-package-next-contact) > + (note gnu-package-note)) I’d remove these 5 fields since Brandon mentioned that at least 2 of them are being moved elsewhere, and we don’t need them anyway. (It’s surprising that there’s no ‘license’ field in the file.) Thanks! Ludo’.
